Open
Conversation
Contributor
Author
|
are you still working on that ? |
Owner
|
This needs to be in a sub-package. I started to work on it and then didn't have time to finish. I don't have a use for the code at the moment, but if you want to refactor it out into a sub-package that would be great. |
Contributor
Author
|
I don't really get the subpackage idea Same thing for the flac format |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch reads the first mp3 frames, with support for the XING header to speed things up
It adds some sanity check (for example a flac file with an id3 tag will be rejected)
I tested it against 20k mp3.
Without the patch, it takes 19s to scan the whole library
With the patch, it takes 52s
I still have some checks to do. I want to compare the result with other tool I know are working fine
Next step : adding the support for mp4 and flac files ; should be easier